Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for latest redis-doc #328

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fixes for latest redis-doc #328

merged 1 commit into from
Sep 17, 2021

Conversation

mmkal
Copy link
Owner

@mmkal mmkal commented Sep 17, 2021

Fixes #324

Supersedes #327

Fixes/patches required:

@codecov-commenter
Copy link

Codecov Report

Merging #328 (dab9383) into main (fa3bc19) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          484       501   +17     
  Branches       105       110    +5     
=========================================
+ Hits           484       501   +17     
Impacted Files Coverage Δ
codegen/generate-client.ts 100.00% <100.00%> (ø)
codegen/generate-tests.ts 100.00% <100.00%> (ø)
codegen/patches/schema.ts 100.00% <100.00%> (ø)
codegen/patches/tests.ts 100.00% <100.00%> (ø)
codegen/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f38d3...dab9383. Read the comment docs.

@mmkal mmkal marked this pull request as ready for review September 17, 2021 13:31
@mmkal mmkal merged commit 49744d9 into main Sep 17, 2021
@mmkal mmkal deleted the redis-doc-fixes/2021-09-17 branch September 17, 2021 13:32
mmkal added a commit that referenced this pull request Sep 17, 2021
Fixes #324

Supersedes #327

Fixes/patches required:

- update SET command (redis/redis-doc#1232 still getting no love. I will take that PR to my grave I guess)
- disable redis v7 commands/options tests
- disable non-deterministic command tests (hrandfield etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEOSEARCH support
2 participants