Web Experience Chat #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
force-pushed
the
feature/text-chat
branch
from
a092727
to
a0ac2e7
Compare
example/web-client/src/index.ts
Outdated
| // this.textChatUI?.addTextMessage("testUser", `this is message ${i}`); | ||
| // i++; | ||
| // }, 2000); | ||
| // }, 500); |
example/web-client/src/index.ts
Outdated
| // }, 500); | ||
| } | ||
|
|
||
| private sendMessageToServer = (_clientName: string, message: string): void => { |
There was a problem hiding this comment.
This can use a regular method definition rather than an assignment (remove the =)
example/web-client/src/index.ts
Outdated
| // }, 500); | ||
| } | ||
|
|
||
| private sendMessageToServer = (_clientName: string, message: string): void => { |
There was a problem hiding this comment.
_clientName is unused
MarcusLongmuir
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7
This PR implements text-chat (client and server).
What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?