Fixed #5; A bug with Venmo debit card transactions.

mmohades · Jun 22, 2020 · 6d6bdaa · 6d6bdaa
1 parent 6199ebc
commit 6d6bdaa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/setup.py b/setup.py
@@ -22,7 +22,7 @@ def requirements():
 
 setup(
     name='venmo-api',
-    version='0.1.5',
+    version='0.1.6',
     author="Mark Mohades",
     license="GNU General Public License v3",
     url='https://github.com/mmohades/venmo',

diff --git a/venmo_api/models/transaction.py b/venmo_api/models/transaction.py
@@ -46,8 +46,8 @@ def from_json(cls, json):
         parser = JSONSchema.transaction(json)
         transaction_type = TransactionType(parser.get_transaction_type())
 
-        # Skip money transfers to/from bank accounts and refunds
-        if transaction_type == TransactionType.REFUND or transaction_type == TransactionType.TRANSFER:
+        # Currently only handles Payment-type transactions
+        if transaction_type is not TransactionType.PAYMENT:
             return
 
         date_created = string_to_timestamp(parser.get_date_created())
@@ -83,5 +83,13 @@ def __str__(self):
 
 class TransactionType(Enum):
     PAYMENT = 'payment'
+    # merchant refund
     REFUND = 'refund'
+    # to/from bank account
     TRANSFER = 'transfer'
+    # add money to debit card
+    TOP_UP = 'top_up'
+    # debit card purchase
+    AUTHORIZATION = 'authorization'
+    # debit card atm withdrawal
+    ATM_WITHDRAWAL = 'atm_withdrawal'