Release version 1.2.0 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use header_names instead of column_N if available * Move header check into buildSchema and remove hasHeader parameter * move .forEach to next line to match the formatting of the previous version of this method * Become less functional since ifPresentOrElse is not available in Java 8 * Add test case for custom headers and header extraction off * Format method to look similar to before * Format checkDataWithHeaders to match checkData * Improve readability of buildSchema And rearrange so the case of extracted or user provided headers is handled first and using default headers is handled second This stems from the potentially incorrect assumption that wanting to use provided or extracted headers is more common than wanting to use the default headers * Apply suggestion to buildSchema
This reduces the verbosity of INFO level logs in FsSourceTask from files which are being skipped by the policy or are empty. If users still want to see that they didn't process anything for a file or that they tried to process an empty file they can drop the level down to DEBUG and they'll see the log message on line 105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.