do not export the symbols from the static libraries

mmomtchev · Apr 9, 2024 · 5b692f3 · 5b692f3
1 parent f3d787d
commit 5b692f3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.9]
+
+### Changed
+ - All shared library symbols are now hidden on Linux, allowing the load the binary addon in a process that has loaded a different version of GDAL (on Windows this has always been possible and on maOS, while possible in theory, this particular linking mode is not supported by `node-gyp`)
+
+
 ## [3.8.5] 2024-04-09
 
 ### Added

diff --git a/common.gypi b/common.gypi
@@ -75,7 +75,10 @@
 				"defines": [ "DARWIN" ]
 			}],
 			["OS == 'linux'", {
-				"defines": [ "LINUX" ]
+  			"defines": [ "LINUX" ],
+        "ldflags": [
+          "-Wl,--exclude-libs,ALL"
+        ]
 			}]
 		],
 		"configurations": {