Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RLayerTileWMS refresh when url or other props change #249

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

boborua
Copy link
Contributor

@boborua boborua commented Apr 28, 2024

@mmomtchev
Copy link
Owner

Given that I getting simultaneous notifications related to the ongoing extortion, I would be surprised if you actually cared about this PR while being involved in the extortion? I find the probability that you would be interested in both quite slilm?

In this relatively improbable case, can you add an unit test for this scenario?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 97.72%. Comparing base (20a9ed6) to head (63847ae).

Files Patch % Lines
src/layer/RLayerTileWMS.tsx 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   98.43%   97.72%   -0.71%     
==========================================
  Files          74       74              
  Lines        1535     1541       +6     
  Branches      254      255       +1     
==========================================
- Hits         1511     1506       -5     
- Misses         24       34      +10     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmomtchev mmomtchev merged commit 05f8fbb into mmomtchev:main Apr 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants