Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence detection skips song when channels are muted #131

Closed
applecuckoo opened this issue Apr 6, 2023 · 3 comments
Closed

Silence detection skips song when channels are muted #131

applecuckoo opened this issue Apr 6, 2023 · 3 comments

Comments

@applecuckoo
Copy link

Hi there, if you play Green Hill Zone from the Genesis section and solo FM 1, it skips to the next song after 10 seconds. I believe this is a silence-related timeout, since I tried soloing FM 2 and it doesn't time out.

@mmontag
Copy link
Owner

mmontag commented Apr 29, 2023

Yes, indeed you are correct. game-music-emu library uses silence detection to decide when the track ends. And this is really annoying when muting channels.

I think some tracks do rely on this silence detection, like sound effects or short jingles (will verify).
In that case, one fix would be to disable silence detection whenever track muting is applied.
It might introduce other problems, but still better than current behavior.

  • verify that GME silence detection is needed
  • disable silence detection upon channel mute

@mmontag
Copy link
Owner

mmontag commented May 1, 2023

Merged a fix - let me know if you still have this problem.

@mmontag mmontag closed this as completed May 1, 2023
@mmontag mmontag changed the title Sega Genesis instrument timeout Silence detection skips song when channels are muted May 1, 2023
@mmontag
Copy link
Owner

mmontag commented May 16, 2023

Dupe of #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants