Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coveralls regression with Pull Request #3 #5

Closed
mmoulton opened this issue May 3, 2013 · 1 comment
Closed

Coveralls regression with Pull Request #3 #5

mmoulton opened this issue May 3, 2013 · 1 comment
Assignees
@mmoulton
Labels
bug

Comments

@mmoulton
Copy link
Owner

mmoulton commented May 3, 2013

Since we use the coveralls.io REST API to submit data, they require the repo_token param to be passed in regardless of if the service_name and service_job_id is provided.

Need to revert the changes made in pull request #3 and research ways of pulling in the repo_token value from a .coveralls.yml file if it exists for the project.
@ghost ghost assigned mmoulton May 3, 2013
mmoulton added a commit that referenced this issue May 3, 2013
@mmoulton
Resolving #4: looking for mocha in a sane location (Windows friendly …
e8f4f22 
…too), Resolving #5: reverting the coveralls repo_token regression
@mmoulton
Copy link
Owner Author

mmoulton commented May 4, 2013

Resolved by v0.0.5

@mmoulton mmoulton closed this as completed May 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmoulton mmoulton

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmoulton