Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbrt v4 book formula 13.9 maybe error #365

Open
AndrewChan2022 opened this issue Jul 9, 2023 · 2 comments
Open

pbrt v4 book formula 13.9 maybe error #365

AndrewChan2022 opened this issue Jul 9, 2023 · 2 comments

Comments

@AndrewChan2022
Copy link

AndrewChan2022 commented Jul 9, 2023

simple path trace, direct light evaluate 13.9,
P(pi¯) = Le(pi -> pi-1) * f(pi -> pi-1 -> pi-2) * |cosθi| * V(pi <->pi-1) / (pl(wi) * p(l)) * β

here cosθi should be angle on shading surface, so cosθi-1

the code also using shading point angle.

@AndrewChan2022
Copy link
Author

formula 14.8,
integrate over majorant segment:
third line:
miss σ_maj^3

@AndrewChan2022
Copy link
Author

text 11.2, delta tracking:

If the Russian roulette termination probability at each sampled point is set to be equal to the ratio of σn and σmaj, then the scaling cancels and the estimator becomes
->
termination probability should be 1 - ratio of σn and σmaj

code also using termination probability 1 - σn / σmaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant