Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function Film.ToOutputRGB seems to output negative values in the photon mapper. #398

Open
MaherRayes opened this issue Nov 1, 2023 · 0 comments
Open

Function Film.ToOutputRGB seems to output negative values in the photon mapper. #398

MaherRayes opened this issue Nov 1, 2023 · 0 comments

Comments

@MaherRayes
Copy link

I'm trying to output indirect illumination separately on the photon mapper. However printing pixel.tau / (np * Pi * Sqr(pixel.radius)) gives negative values for some of the RGB channels. I tried to trace the value back and it seem like RGB Phi_i = film.ToOutputRGB(pixel.vp.beta * Phi, photonLambda) is returning negative values.

Is this expected behavior? The final images still look correct to me so I'm a bit confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaherRayes