Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues in recent CI changes #1014

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Nov 4, 2023

There are some issues with the recent CI changes. This PR bumps ci-perf-kit to 0.7.2, which fixes some of them, and separate issues are created for the issue(s) that is not fixed in the PR.

  • ci-perf-kit 0.7.1 allows drawing notes on the graph to show the date where there are known CI environment changes. But it has some issues:
    • Each note is by mistake plotted only once for all the graphs (which means only one graph will have the note). In the Python script, we should copy the note list before processing it.
    • In the case that there is only one run for several notes. (e.g. we have notes on 1101 and 1102, and we have runs on 1103 and 1104. Both notes for 1101 and 1102 should show on the data point for 1103. The current CI plots one note on 1103 and one note on 1104. We should combine the notes on 1101 and 1102, and plot them for the run 1103.
  • 0.7.1 sets the heap size to 8g (for OpenJDK NoGC runs, and mutator runs), but by mistake uses a modifier heap30g. This causes confusion. It should be name as heap8g.
  • 0.7.1 by mistake sets the plan to gencopy in a GenImmix config.

ci-perf-kit 0.7.2 (https://github.com/mmtk/ci-perf-kit/releases/tag/0.7.2) fixes those issues.

@qinsoon qinsoon requested a review from wks November 4, 2023 20:45
@qinsoon qinsoon changed the title Move to ci-perf-kit 0.7.2. Fix some issues with notes on the graph. Move to ci-perf-kit 0.7.3 Nov 4, 2023
@qinsoon qinsoon changed the title Move to ci-perf-kit 0.7.3 Fix multiple issues in recent CI changes Nov 4, 2023
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wks wks added this pull request to the merge queue Nov 6, 2023
Merged via the queue into mmtk:master with commit d253d97 Nov 6, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants