Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ci-perf-kit 0.7.4: ignore runs with unmatched key/value in the logs. #1025

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Nov 14, 2023

The perf CI run for mutator performance recently failed for the following error:

++ python3 scripts/mutator_report.py /home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/result_repo/mutator /home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/reports/master
Traceback (most recent call last):
  File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/mutator_report.py", line 43, in <module>
    run_id, results = parse.parse_run(os.path.join(result_repo_mutator_root, l))
  File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/parse.py", line 82, in parse_run
    results.append(parse_log(os.path.join(log_folder, l), n_invocations))
  File "/home/gitlab-runner/actions-runner/_work/mmtk-core/mmtk-core/ci-perf-kit/scripts/parse.py", line 48, in parse_log
    assert len(mmtk_keys) == len(mmtk_values), "Error when reading MMTk statistics: num of keys does not match num of values"
AssertionError: Error when reading MMTk statistics: num of keys does not match num of values

One of the runs recently has an incomplete MMTk Statistics printing. The process quit for some reason before it prints the values. This seems to be a random issue, as the other runs in the same log file look fine.

============================ MMTk Statistics Totals ============================
GC time.other time.stw time.jitc time.ygc collections.young time.ogc collections.old

The unmatched key/value pairs caused an assertion failure in the ci-perf-kit script.ci-perf-kit 0.7.4 (https://github.com/mmtk/ci-perf-kit/releases/tag/0.7.4) fixes this. Runs that do not have valid key/value pairs will be ignored, and the script will not quit.

@qinsoon qinsoon requested a review from wks November 14, 2023 10:52
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Nov 15, 2023
Merged via the queue into mmtk:master with commit da9fb1f Nov 15, 2023
19 checks passed
@qinsoon qinsoon deleted the fix-perf-ci-unmatched-key-value branch November 15, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants