Revert a mistake in v0.22 that prevents cargo publish #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caizixian
requested changes
Jan 11, 2024
.github/workflows/cargo-publish.yml
Outdated
| echo "Wait for Retry #"$n | ||
| sleep 60 | ||
| echo "Attempt #"$n | ||
| false && { success=true; break; } |
There was a problem hiding this comment.
false is probably from testing but it should be cargo publish
caizixian
approved these changes
Jan 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Bumps the version to v0.22.1 for #1065.
qinsoon
added a commit
that referenced
this pull request
Jan 12, 2024
#1055 removed the version for `mmtk-macros` in `Cargo.toml`. I thought it was fine, as it uses a local path as the dependency. But `cargo publish` actually requires all the dependencies to specify a version. So `cargo publish` failed for https://github.com/mmtk/mmtk-core/releases/tag/v0.22.0 in https://github.com/mmtk/mmtk-core/actions/runs/7284255107/job/19849376243. The action did not return a non-zero code so I was not aware of the issue. `v0.22` was not published to `crates.io`. This PR adds back the version for `mmtk-macros`, adds a check for `cargo publish` dry run in the style check, and fixes the publish script so the script properly fails if all the attempts of `cargo publish` fail.
qinsoon
added a commit
that referenced
this pull request
Jan 12, 2024
Bumps the version to v0.22.1 for #1065.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1055 removed the version for
mmtk-macrosinCargo.toml. I thought it was fine, as it uses a local path as the dependency. Butcargo publishactually requires all the dependencies to specify a version. Socargo publishfailed for https://github.com/mmtk/mmtk-core/releases/tag/v0.22.0 in https://github.com/mmtk/mmtk-core/actions/runs/7284255107/job/19849376243. The action did not return a non-zero code so I was not aware of the issue.v0.22was not published tocrates.io.This PR adds back the version for
mmtk-macros, adds a check forcargo publishdry run in the style check, and fixes the publish script so the script properly fails if all the attempts ofcargo publishfail.