Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a document for project principles #1069

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add a document for project principles #1069

merged 1 commit into from
Jan 15, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 15, 2024 •
edited

This PR adds a document under /docs for project principles as we discussed in #56. This closes #56.

@qinsoon qinsoon marked this pull request as ready for review January 15, 2024 06:28
@qinsoon qinsoon requested a review from wks January 15, 2024 06:28
wks
wks approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Jan 15, 2024
Merged via the queue into mmtk:master with commit 33c736e Jan 15, 2024
19 checks passed
@qinsoon qinsoon deleted the doc-dev-principles branch January 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Principles
2 participants
@qinsoon @wks