Rename CI tests to minimal/extended tests #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
binding-refs |
wks
reviewed
Jan 19, 2024
| * Minimal tests run unconditionally for every pull request and for every commit. This set of tests aims to finish within half an hour. | ||
| This include tests from the `mmtk-core` repo and integration tests from binding repos. Integration tests with a binding in the minimal tests should | ||
| focus on testing MMTk core features that is exclusively used for the binding. | ||
| * Extended tests only run for a pull request if the pull request is tagged with the label `PR-extended-testing`. This set of tests |
There was a problem hiding this comment.
But extended-tests-bindings.yml still mentions PR-testing. Should that be changed, too?
There was a problem hiding this comment.
Yes. I made that change.
|
@wks Ruby tests kept failing in all the attempts. You may want to look into it. It should not be related to this PR, and I may merge this PR along with the OpenJDK PR. |
|
I can reproduce the Rust bug locally, but not stably. It is very random. It happens during GC when marking lines. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
We renamed CI tests in #1073, but forgot to rename them in the ignored list for the merge check. This PR fixes this.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
The extended tests for OpenJDK reuses a workflow, so its action name is different. We did not use the correct action name since #1073. It manifested as the merge check was waiting for the OpenJDK tests to finish and checked its result before it finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the CI workflows for #935, and run some OpenJDK tests as minimal tests.