Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue that the aligned VM space may not match the original location #809

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix an issue that the aligned VM space may not match the original location #809

merged 2 commits into from
May 8, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented May 8, 2023 •
edited

This PR fixes an issue that if the given VM space start and size is not aligned to chunks, the aligned start and size is calculated wrong.

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label May 8, 2023
@qinsoon qinsoon marked this pull request as ready for review May 8, 2023 08:34
@qinsoon qinsoon requested a review from wks May 8, 2023 08:35
wks
wks approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit ba7cda0 into mmtk:master May 8, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qinsoon @wks