Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sysinfo instead of sys-info-rs #827

Merged
merged 3 commits into from
May 22, 2023
Merged

Use sysinfo instead of sys-info-rs #827

merged 3 commits into from
May 22, 2023

Conversation

k-sareen
Copy link
Collaborator

No description provided.

@k-sareen k-sareen requested a review from qinsoon May 22, 2023 00:40
@qinsoon
Copy link
Member

qinsoon commented May 22, 2023

The tests failed on i686-linux. @k-sareen

@k-sareen
Copy link
Collaborator Author

Huh. That's very odd. How do I run 32-bit tests locally?

@qinsoon
Copy link
Member

qinsoon commented May 22, 2023

Huh. That's very odd. How do I run 32-bit tests locally?

Roughly cargo test --target i686-unknown-linux-gnu.

@k-sareen
Copy link
Collaborator Author

k-sareen commented May 22, 2023 •
edited

It fails because of u64 -> usize conversion on 32-bit. We should return u64 always I feel like. Previously it did as usize which works.

@k-sareen
Copy link
Collaborator Author

Fixed @qinsoon. 32-bit tests pass now

qinsoon
qinsoon approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon mentioned this pull request May 22, 2023
Open
@k-sareen
Copy link
Collaborator Author

I'll merge after the tests finish running

@wks wks mentioned this pull request May 22, 2023
Merged
@k-sareen k-sareen merged commit 440b57c into mmtk:master May 22, 2023
14 checks passed
@wks wks mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-sareen @qinsoon