-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update porting guide #857
Update porting guide #857
Conversation
@wks You can add some text if you want to. I'm currently just working on the NoGC port. The current porting guide doesn't talk about the Rust side at all. |
I'm currently not linking the ART binding because: (a) it's incomplete; and (b) it's not official. |
|
I don't know why that error disappeared, but this should fix it. I just merge a PR that includes the change. Line 55 in 02b57a9
|
I'd like to add a new page dedicated to the overall steps of porting a new VM, basically rewriting the removed "steps" in another page. But I think I can do it in another PR so yours can be merged first. |
Those steps exist here: https://github.com/mmtk/mmtk-core/blob/master/docs/portingguide/src/howto/prefix.md You could edit it in this same PR. I'm not touching that file anymore. |
I've only updated the NoGC text. I've not added anything about porting next steps. I thought I would make it a separate PR, but I can add it to this PR if you think it would be better. |
@qinsoon Thank you for the review. I've addressed the comments. Let me know if I should change anything further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.