Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update porting guide #857

Merged
merged 14 commits into from
Jun 23, 2023
Merged

Update porting guide #857

merged 14 commits into from
Jun 23, 2023

Conversation

k-sareen
Copy link
Collaborator

No description provided.

@k-sareen k-sareen marked this pull request as draft June 21, 2023 04:03
@k-sareen
Copy link
Collaborator Author

k-sareen commented Jun 21, 2023

@wks You can add some text if you want to. I'm currently just working on the NoGC port. The current porting guide doesn't talk about the Rust side at all.

@k-sareen
Copy link
Collaborator Author

I'm currently not linking the ART binding because: (a) it's incomplete; and (b) it's not official.

@k-sareen
Copy link
Collaborator Author

k-sareen commented Jun 21, 2023

@qinsoon We have to bump the MSRV to 1.64 it seems like. Not building due to some dependency update. Nevermind. Seemed like a transient error?

@qinsoon
Copy link
Member

qinsoon commented Jun 21, 2023

@qinsoon We have to bump the MSRV to 1.64 it seems like. Not building due to some dependency update. Nevermind. Seemed like a transient error?

I don't know why that error disappeared, but this should fix it. I just merge a PR that includes the change.

built = { version = "=0.6.0", features = ["git2"] }

@wks
Copy link
Collaborator

wks commented Jun 21, 2023

@wks You can add some text if you want to. I'm currently just working on the NoGC port. The current porting guide doesn't talk about the Rust side at all.

I'd like to add a new page dedicated to the overall steps of porting a new VM, basically rewriting the removed "steps" in another page. But I think I can do it in another PR so yours can be merged first.

@k-sareen
Copy link
Collaborator Author

@wks You can add some text if you want to. I'm currently just working on the NoGC port. The current porting guide doesn't talk about the Rust side at all.

I'd like to add a new page dedicated to the overall steps of porting a new VM, basically rewriting the removed "steps" in another page. But I think I can do it in another PR so yours can be merged first.

Those steps exist here: https://github.com/mmtk/mmtk-core/blob/master/docs/portingguide/src/howto/prefix.md

You could edit it in this same PR. I'm not touching that file anymore.

@k-sareen k-sareen marked this pull request as ready for review June 21, 2023 09:46
@k-sareen k-sareen requested review from qinsoon and wks June 21, 2023 09:46
@k-sareen
Copy link
Collaborator Author

I've only updated the NoGC text. I've not added anything about porting next steps. I thought I would make it a separate PR, but I can add it to this PR if you think it would be better.

docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
docs/portingguide/src/howto/nogc.md Outdated Show resolved Hide resolved
@k-sareen
Copy link
Collaborator Author

@qinsoon Thank you for the review. I've addressed the comments. Let me know if I should change anything further.

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-sareen k-sareen merged commit f739fbb into mmtk:master Jun 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants