Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around stack overflow in array_from_fn #876

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

wks
Copy link
Collaborator

@wks wks commented Jul 31, 2023

It should fix a crash in JikesRVM caused by overflown stack overwriting objects in the VM space.

Fixes: #874

It should fix a crash in JikesRVM caused by overflown stack overwriting
objects in the VM space.
@wks wks requested a review from qinsoon July 31, 2023 11:06
sysinfo requires Rust 1.63 since version 0.29.6.  Temporarily fix its
version until we bump our MSRV.
@qinsoon
Copy link
Member

qinsoon commented Jul 31, 2023

binding-refs
JIKESRVM_BINDING_REPO=qinsoon/mmtk-jikesrvm
JIKESRVM_BINDING_REF=set-e-in-ci-test
JULIA_BINDING_REPO=mmtk/mmtk-julia
JULIA_BINDING_REF=fix-ci-test

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Jul 31, 2023
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@qinsoon qinsoon removed the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Aug 1, 2023
@wks wks merged commit f780a11 into mmtk:master Aug 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #849 broke JikesRVM RBaseBaseSemiSpace
2 participants