Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ready to merge check for PRs #928

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Run ready to merge check for PRs #928

merged 2 commits into from
Aug 30, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 30, 2023 •
edited

This PR does two changes:

  • Run msrv check for merge group. We want this test to pass in order to merge a PR.
  • Run ready-to-merge check for pull requests. As we want to set ready-to-merge as the required check for merging, we have to run this check for a PR.

@qinsoon qinsoon marked this pull request as ready for review August 30, 2023 05:25
@qinsoon qinsoon requested a review from wks August 30, 2023 05:32
wks
wks approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Aug 30, 2023
Merged via the queue into mmtk:master with commit 0532037 Aug 30, 2023
16 of 19 checks passed
@qinsoon qinsoon deleted the run-ready-to-merge-check-for-prs branch August 30, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qinsoon @wks