Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a delay before we enable auto merge on a PR #992

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Oct 22, 2023

We saw the auto merging workflow (added in #988) failed in https://github.com/mmtk/mmtk-core/actions/runs/6587030083/job/17896533403. The error message was GraphQL: Head branch is out of date. Review and try the merge again. (mergePullRequest). It is likely caused by the issue https://github.com/orgs/community/discussions/24462: When a PR gets updated, Github has a process to determine if the PR is mergable. If we attempt to enable auto merge before the process is done, the merge will fail with the error message above. This PR adds a delay and retry for enabling auto merging.

@qinsoon qinsoon requested a review from wks October 22, 2023 23:11
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Oct 23, 2023
Merged via the queue into mmtk:master with commit eaa203e Oct 23, 2023
19 checks passed
@qinsoon qinsoon deleted the add-delay-before-auto-merge branch October 23, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants