Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude kernel events from perf results #995

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

k-sareen
Copy link
Collaborator

This commit adds an option to exclude kernel events from perf results. We include kernel events by default. Note that previously kernel events were excluded by default.

This commit adds an option to exclude kernel events from perf results.
We include kernel events by default. Note that previously kernel events
were excluded by default.
Cargo.toml Outdated Show resolved Hide resolved
@k-sareen
Copy link
Collaborator Author

@wenyuzhao Perhaps you can use this PR to check if it fixes the issue you noticed. I'm not sure what it exactly was, so I can't reproduce it.

@k-sareen
Copy link
Collaborator Author

@wenyuzhao Can you confirm the issue you noticed has been resolved? I'll merge this PR (after bumping the pfm crate version) if that is the case.

@wenyuzhao
Copy link
Member

wenyuzhao commented Oct 28, 2023

@wenyuzhao Can you confirm the issue you noticed has been resolved? I'll merge this PR (after bumping the pfm crate version) if that is the case.

Yes confirming this fix is working. Thanks.

@k-sareen k-sareen added this pull request to the merge queue Oct 29, 2023
Merged via the queue into mmtk:master with commit 23ff088 Oct 29, 2023
18 of 19 checks passed
@k-sareen k-sareen deleted the include-kernel-perf branch October 29, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants