remove javascript warning when clicking on leaf element #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2022 20:16
when clicking on leaf element, there is a javacript warning Uncaught TypeError: n is null
javascript-minifier.com redirect to https://www.toptal.com/developers/javascript-minifier/ and war that API endpoint has changed
|
Wow... I'm not sure how I never noticed this before. Maybe I don't click on a lot of leaf elements :) I'm OK with the change that tests if the element is null. What's up with the other change to the minimizing URL? |
|
just that when i tried to use to command line to minify the .js I got an error. Going to javascript-minifier.com, i got redirected to https://www.toptal.com/developers/javascript-minifier/ so I just updated the URL. |
mmucklo
reviewed
Apr 19, 2022
js/krumo.js
Outdated
| event.stopPropagation(); | ||
| return; | ||
| } | ||
| is_expanded = !elem.classList.contains("krumo-opened"); |
There was a problem hiding this comment.
You can move the var is_expanded to here.
There was a problem hiding this comment.
ok, I moved the variable declaration
|
This looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when clicking on leaf element, there is a javacript warning
Uncaught TypeError: n is null
By testing and exiting early if event.target.closest(".krumo-expand") returned null, the javascript warning disapears