Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Do not display score word OK when min length is not met #39

Closed
binarykitchen opened this issue May 29, 2017 · 2 comments
Closed

Do not display score word OK when min length is not met #39

binarykitchen opened this issue May 29, 2017 · 2 comments
Labels
enhancement

Comments

@binarykitchen
Copy link
Contributor

When you have set a min length of i.E. 8 and enter a shorter password which DOES meet the min score, the input score word is OK which is irritating.

Should display too short or something like that.
@mmw
Copy link
Owner

mmw commented May 31, 2017

This should be an option/toggle. Having the word OK for the lowest password strength score feels incorrect fwiw. Feel free to submit a PR, otherwise I'll get to it when I have some free time

@binarykitchen binarykitchen mentioned this issue Jun 1, 2017
Merged
@binarykitchen
Copy link
Contributor Author

here you go @mmw

mmw pushed a commit that referenced this issue Jun 14, 2017
@binarykitchen @mmw
Better min length validation and ammends input class names instead. (#40
d49b31f 
)

Fixes issues #38 and #39, also improves documentation and tests.
@mmw mmw closed this as completed Jun 14, 2017
mmw pushed a commit that referenced this issue Dec 12, 2017
@binarykitchen @mmw
Better min length validation and ammends input class names instead. (#40
d176d64 
)

Fixes issues #38 and #39, also improves documentation and tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binarykitchen @mmw