Priority: Fixes to development after DMA addition #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some stuff I ran into after updating git on all my machines. Notably, this is restoring some stuff in the
Makefile
.I must say I'm a bit bemused by this; the stuff that got in your way was plain deleted. At the very least, you could have commented them out with a note. Even better, keep the given changes local and don't submit them.
I would propose that, rather than sweeping the problems under a rug, it's better to try and fix them. I believe that these additions, which were indeed all mine, are significant. I also think that you believe that too, since you accepted the PR's.
In any case, they're back now. I would propose merging this, and then test the fixes in the other PR's for the issues. If these solutions are not adequate, it would be very helpful if you examined the problems on your Pi, since that is where they originate.