Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 2 tests for markdown replace_links function #28

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Rachit1313
Copy link
Contributor

@Rachit1313 Rachit1313 commented Nov 17, 2023

Pull Request Description:

Summary

This pull request adds two test cases to further validate the functionality of the replace_links function. The new tests cover scenarios involving broken links in Markdown content and valid links in plain text content.

Changes Made

  1. Test replace_links with a broken link in markdown content:

    • Input: "Test content with a broken link"
    • Expected Output: 'Test content with a broken link'
    • Assertion: Ensure the function correctly handles and identifies broken links in Markdown content.
  2. Test replace_links with valid link in plain text content:

Additional Information

These tests enhance the test coverage for the replace_links function, addressing specific scenarios related to broken links in Markdown and valid links in plain text. The existing test suite is expanded to ensure comprehensive testing of the function's capabilities.

This change is intended to improve the overall robustness of the codebase and validate the correctness of the link replacement logic in various contexts.

Checklist

  • All tests pass successfully.
  • Code is formatted and adheres to the project's coding standards.
  • Documentation, if applicable, is updated to reflect the changes.

Copy link
Owner

@mnajibi mnajibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed. Thanks for contributing

@mnajibi mnajibi merged commit 6990c1b into mnajibi:main Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants