Update to match with Laravel 5.7 #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing some value in the lines from Laravel to reflect the newest 5.7 version. Also added some instructions to make it clearer to follow.
mnapoli
reviewed
Dec 4, 2018
|
The build is failing on master so this is not your PR (if anyone is up to fixing it BTW) so don't worry about it. |
Update to reflect the new ENV variables used by Laravel 5.7 such as APP_BASE_PATH and VIEW_COMPILED_PATH.
incoming-th
commented
Dec 4, 2018
mnapoli
reviewed
Dec 4, 2018
| - 'compiled' => realpath(storage_path('framework/views')), | ||
| - 'compiled' => env( | ||
| - 'VIEW_COMPILED_PATH', | ||
| - realpath(storage_path('framework/views')) | ||
| + 'compiled' => storage_path('framework/views'), |
There was a problem hiding this comment.
I believe we can now remove this whole bit because of the VIEW_COMPILED_PATH variable in .env?
There was a problem hiding this comment.
Yes you are correct, sorry for this was using online editor. I will review all in one shot and submit a better version.
mnapoli
reviewed
Dec 4, 2018
| # We cannot store sessions to disk: if you don't need sessions (API, etc.) use `array`, else store sessions in database | ||
| SESSION_DRIVER=array | ||
| # Logging to stderr allows the logs to end up in Cloudwatch | ||
| LOG_CHANNEL=stderr | ||
| # This allows to generate relative file paths for the lambda | ||
| # This allows to generate relative file paths for the lambda because when generating the optimized config absolute paths will be everywhere and they will not work because your machine and the lambda environment do not match. | ||
| # To avoid that problem, set APP_BASE_PATH variable will allow us to replace the absolute path by `.` (relative path) when generating the lambda. | ||
| APP_DIR=. |
There was a problem hiding this comment.
APP_DIR should be replaced by the official APP_BASE_PATH variable now.
There was a problem hiding this comment.
Correct again my mistake.
|
This is great that means less things to override! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing some value in the lines from Laravel to reflect the newest 5.7 version. Also added some instructions to make it clearer to follow.