Small fix to run migrations queries without a transaction #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de still default mode) for dbms without support of DDL statements in a transaction
mnapoli
reviewed
Dec 20, 2022
mnapoli
reviewed
Feb 21, 2023
| @@ -23,15 +23,15 @@ public function __construct(Connection $db, SchemaDefinition $schemaDefinition) | |||
| /** | |||
| * Update the database schema to match the schema definition. | |||
| */ | |||
| public function update(bool $force, OutputInterface $output): void | |||
| public function update(bool $force, OutputInterface $output, bool $withTransaction = false): void | |||
There was a problem hiding this comment.
The default behavior will change to not use transactions. Could we preserve the existing behavior?
There was a problem hiding this comment.
Yes, but the initial PR was not change the default behavior, but you proposed to switch the default behavior : #12 (comment) Or want you just change behavior of options but not the method ?
There was a problem hiding this comment.
@frenchcomp OMG sorry 😅
I have so many prs and issues to track that I'm not remembering all the details, but thank you for clarifying! That sounds great then, I'll merge!
There was a problem hiding this comment.
I understand, thanks you for the merge and yours works :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option --no-transactions / -n to disable transaction to run migrations queries to fix #11