-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 6 #9
Conversation
* Require doctrine/migrations 3.1.2 for PSR-12 formatting.
@mnapoli This should be green now. |
I don't understand why that error is popping up 🤔 If that makes things easier we can also drop PHP 7.4? Not sure if that would help here. |
@mnapoli Didn’t make sense to me either, so dropping PHP 7.4 support. |
Hey @mnapoli, do you agree with this change? If so, would be cool to have this merged & tagged. |
@@ -29,6 +29,6 @@ jobs: | |||
tools: composer:v2 | |||
coverage: none | |||
- name: Install PHP dependencies | |||
run: composer update ${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-progress --no-suggest --ignore-platform-reqs | |||
run: composer update ${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-progress --ignore-platform-req=ext-pdo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t ignore the PHP version when installing dependencies to prevent doctrine/dbal version being installed that is incompatible with PHP 8.0. Only ignore the PDO requirement.
Also, --no-suggest
is deprecated, so remove it.
Yes I'm 👍 to merge this, tests are still causing issue though |
@mnapoli Hmm, that seems to be a result of the release of doctrine/migrations 3.4, which changed the formatting of the migration file (again). How important is it for this library to test |
I guess it would work as long as it tests the feature 😄 |
Changed the test to only compare the contents of the SQL statements, ignoring any changes in the migration’s PHP code. |
Thank you for your patience :) |
in the migration’s PHP code, as introduced in e.g.
Update the default migration template to adhere to PSR 12 formatting doctrine/migrations#875.