Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "traditional" PHP config files #17

Merged
merged 1 commit into from
Feb 5, 2017

Conversation

mnapoli
Copy link
Owner

@mnapoli mnapoli commented Feb 5, 2017

Since the loader loads all .php files, it will replace and override completely the Symfony\Component\DependencyInjection\Loader\PhpFileLoader loader.

As such, it must support files loaded by Symfony\Component\DependencyInjection\Loader\PhpFileLoader (to keep backward compatibility).

This need turned out necessary when trying to actually use the "fluent" config format in the Symfony standard edition.

Since the loader loads all `.php` files, it will replace and override completely the `Symfony\Component\DependencyInjection\Loader\PhpFileLoader` loader.

As such, it must support files loaded by `Symfony\Component\DependencyInjection\Loader\PhpFileLoader` (to keep backward compatibility).

This need turned out necessary when trying to actually use the "fluent" config format in the Symfony standard edition.
@mnapoli mnapoli force-pushed the support-traditional-config-files branch from a0911d6 to ff8d6ed Compare February 5, 2017 17:34
@mnapoli mnapoli merged commit acfb76f into master Feb 5, 2017
@mnapoli mnapoli deleted the support-traditional-config-files branch February 5, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant