Feature/1 autowiring definitions #4
Conversation
| $this->definition->setAutowired(true); | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
I don't see the point of having this? To me it duplicates autowire()
There was a problem hiding this comment.
It ist some kind of duplication, yes. Instead of this method, i could add a parameter to the constructor.
|
Except my comment above this looks really great! |
|
I changed the code, so that we have no duplication. If you're happy with the solution, let me stash the commits before merging. I thought about moving all methods of the CreateDefinitionHelper to a base class and make a specialization for the autowiring. When the next "special helper function" comes, we'd need another parameter in the constructor, which could get confusing. But perhaps i think to far in the context of this PR. Thoughts? |
|
👍 for merging. I'm fine to merge commits as they are, or feel free to rebase. Let me know. |
|
Oh also I forgot please add docs to the README if you have time. If you don't I'll add them later. |
|
Yeah, will do so, as soon as i'm at my notebook. |
|
Ping @mnapoli |
|
Awesome thanks! |
Implements Issue #1.