Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows #14

Closed
alexconrad opened this issue Jun 27, 2019 · 0 comments · Fixed by #18
Closed

Windows #14

alexconrad opened this issue Jun 27, 2019 · 0 comments · Fixed by #18
Labels

Comments

@alexconrad
Copy link

Due to an undisclosed need, i had to run pretty on Windows.
When running pretty i got:

ERROR: PHP CodeSniffer does not seem to be installed because the 'phpcs' program cannot be found.

It was strange because i had phpcs installed and i could run it just fine. After looking trough this code i noticed that the error message comes from:

function commandExists($command)
{
    $return = shell_exec('which ' . escapeshellarg($command));
    return !empty($return);
}

which cannot be installed on Windows, so i just changed the above code to

function commandExists($command)
{
   return true;
}

And poof everthing started working just fine :)
Hope this will help somebody else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants