test: Increased the coverage. Dropped testing with old node.js versions.

mnasyrov · Jul 25, 2021 · c26cf19 · c26cf19
1 parent a805a52
commit c26cf19
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 24 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2-beta
+      - uses: actions/setup-node@v2
         with:
           node-version: '16'
       - name: Install dependencies
@@ -24,23 +24,3 @@ jobs:
         uses: coverallsapp/github-action@master
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-
-  test-compatibility:
-    needs: test
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node: ['12', '14', '16']
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2-beta
-        with:
-          node-version: ${{ matrix.node }}
-      - name: Install dependencies
-        run: npm ci
-      - name: Build
-        run: npm run build
-      - name: Lint
-        run: npm run lint
-      - name: Test
-        run: npm run test
diff --git a/packages/rx-effects/src/effect.test.ts b/packages/rx-effects/src/effect.test.ts
@@ -6,6 +6,7 @@ import {
   of,
   tap,
   throwError,
+  timeout,
   timer,
 } from 'rxjs';
 import { switchMap, take, toArray } from 'rxjs/operators';
@@ -164,14 +165,29 @@ describe('Effect', () => {
       const effect = createEffect((value: number) => value * 2);
 
       const onSourceFailed = jest.fn();
-      effect.handle(throwError(new Error('test error')), {
-        onSourceFailed,
-      });
+      effect.handle(
+        throwError(() => new Error('test error')),
+        {
+          onSourceFailed,
+        },
+      );
 
       expect(onSourceFailed).toBeCalledTimes(1);
       expect(onSourceFailed).toBeCalledWith(new Error('test error'));
     });
 
+    it('should do nothing in case the event source throws an error and onSourceFailed callback is not provided', async () => {
+      const effect = createEffect((value: number) => value * 2);
+
+      const finalPromise = firstValueFrom(effect.final$.pipe(timeout(10)));
+
+      expect(() =>
+        effect.handle(throwError(() => new Error('test error'))),
+      ).not.toThrowError();
+
+      await expect(finalPromise).rejects.toThrowError('Timeout has occurred');
+    });
+
     it('should handle error from the source', async () => {
       const effect = createEffect((value: number) => value * 2);