Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenopoly only emits the first error #112

Closed
mnater opened this issue Apr 14, 2020 · 1 comment · Fixed by #113
Closed

Hyphenopoly only emits the first error #112

mnater opened this issue Apr 14, 2020 · 1 comment · Fixed by #113
Assignees
Labels

Comments

@mnater
Copy link
Owner

mnater commented Apr 14, 2020

If there are multiple errors (e.g. multiple required languages that are not used on the webpage) only the first error is printed to the console.

(The same issue would probably occur with other events).

@mnater mnater added the bug label Apr 14, 2020
@mnater mnater self-assigned this Apr 14, 2020
@mnater mnater added this to the next bugfix release milestone Apr 14, 2020
@mnater
Copy link
Owner Author

mnater commented Apr 15, 2020

The problem is, that promises can only fullfill once and are then settled (What I didn't realize when I implemented it. I'm always learning new things :-)

So I'll need to move back to the preceding event implementation...

mnater added a commit that referenced this issue Apr 16, 2020
Fixes #112, [skip travis-ci]
@mnater mnater linked a pull request Apr 16, 2020 that will close this issue
mnater added a commit that referenced this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant