-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loader overwrite #195
Comments
If you like this idea, I would create a PR for this |
Hi This sounds very interesting. I look forward to your pull request. Kind regards, PS: feel free to communicate in german. |
Ok, ich schaue wann ich das schaffe. Vermutlich aber noch diese Woche. |
Noch keine Zeit gefunden. :/ |
Es eilt ja auch nicht. |
@mnater done! it's a |
Problem: `import fs from "node:fs"` is not always feasible. Solution: Leave the mechanism to load wasm files to the user of the script. It is required now to configure a `loader` function. Notes: - hyphenopoly.deno.js is not longer needed - Tests and docs are updated accordingly Fixes #195, Fixes #196
Hi, first of all, great project. We really like it.
But we have a few problems integrating it. The dynamic loader gives us real troubles. We use the node-version also in the browser since we want better control over the hyphenation and pretty much only hyphenate strings and do the rendering with mithril.js.
Currently the the loader autodetects the environment. This is not really useful for us. A better option would be to have an optional argument
loader
which pretty much has the same signature as readFile. This would greatly improve usability. It also would allow to prefetch/embed certain lang files and treeshare the loader out of the package and rely on the user solution for loadingThe text was updated successfully, but these errors were encountered: