Refactor #115
Merged
Refactor #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enhance event registering * enhance createDOMHyphenator() * enhance registerSubstitutions (remove eachKey()) [skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
feat: Subject refactor: convert all user settings to Map Problem: Object value access with brackets may induce some security issues. https://github.com/nodesecurity/eslint-plugin-security/blob/master/docs/the-dangers-of-square-bracket-notation.md Solution: Convert all values in H.setup to Maps. Notes: [skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
[skip travis-ci]
TODO: doc and examples
refactor: make 990d0d5 not breaking Problem: Making H.hyphenators a Map required API changes (calling Hyphenopoly.hyphenators.get("<lang>") instead of Hyphenopoly.hyphenators.<lang> Solution: Put a Proxy before the hyphenators Map allowing dot-getters [skip travis-ci]
[skip travis-ci]
[skip travis-ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring goals: