Added TextDecoder require to fix node version 10.x

[yashha]

We found that the module.js does not support node version 10.x.
There seems to be an issue that TextDecoder is not imported and so cannot be found in that version.

The related ticket is:
danburzo/percollate#114

Best Regards

[mnater]

Hi

First of all, thank you for the PR.
I understood what problem it solves, but I have my reservations about it.

1. Node v10 reaches End of Life in a few months. Is it still worthwhile to support?
2. If we decide to do so and if we import the TextDecoder from "util", the module is no longer compatible with Browserify and WebPack. So we would have to make a conditional require.

See also #153

What do you think?

[yashha]

Thanks for the quick response.

I would say when it is a quick fix, then we do the fix, because the EoL is not reached.
Why is TextDecoder from util is not compatible with Browserify and Webpack?
The tests run through properly, maybe we should add tests for browserify and webpack?

[danburzo]

If we decide to do so and if we import the TextDecoder from "util", the module is no longer compatible with Browserify and Webpack. So we would have to make a conditional require.

Yes, when I made the comment in the percollate PR, I was thinking along the lines of:

let TD = typeof TextDecoder !== 'undefined' ? TextDecoder : require('util').TextDecoder;

If indeed that's the only incompatibility with Node 10, it would be nice to support it.

As for the quesstion raised in #153 re: testing in Node LTS versions, maybe a simple GitHub Action like we have here might do the trick, at least for the tap-based tests?

[mnater]

Nice! Thank you!