Process Faces dataset #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mne-tools#41 Remaining / highlightes issues: - Original dataset doesn't store fine-calibration and crosstalk files according to BIDS, so not doing Maxwell filtering for now - I'd like to calculate the contrast of "face" vs "scrambled", however, to do that, I'd need to merge the "familiar" and "unfamiliar" events to "faces". We need to add support for operations like this. Tests will fail until mne-tools/mne-bids#680 has been merged.
|
Whoops this doesn't address #41! I misread the dataset used there… it wasn't ds000117! Hmm… oh well… but this one isn't too bad either! 😅 |
agramfort
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining / highlighted issues:
Original dataset doesn't store fine-calibration and crosstalk files according to BIDS, so not doing Maxwell filtering for now
I'd like to calculate the contrast of "face" vs "scrambled", however, to do that, I'd need to merge the "familiar" and "unfamiliar" events to "faces". We need to add support for operations like this.
Tests will fail until mne-tools/mne-bids#680 has been merged.