BUG: Fix bug with empty room processing #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
changed the title
|
Okay turns out the epochs were okay because we already use the min across runs, so I adjusted the change log and title. I still think #760 is probably the best way to deal with this issue for now, especially when (later) combined with empirical rank estimation which will be necessary for movement compensation. |
|
@hoechenberger feel free to merge if you're happy, I think it should fix the bug but even if it doesn't is a nice/helpful refactor (again) |
|
... I also realized that the head pos text file was being written as |
hoechenberger
approved these changes
Jul 10, 2023
|
Thanks @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)@allermat can you try this branch? In theory you should not need to delete any derivatives, just update to this branch and run.
Closes #759
Only mentioning the
epochsbug fix here since the one @allermat is actually hitting is a within-release (within the last week I think!) bugfix