Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example file name #1

Closed
ktavabi opened this issue Jul 12, 2017 · 4 comments
Closed

Example file name #1

ktavabi opened this issue Jul 12, 2017 · 4 comments

Comments

@ktavabi
Copy link
Contributor

ktavabi commented Jul 12, 2017

Is there a particular reason the example file is called 'plot_mne_sample'? is there a final intention to plot something?

@jasmainak
Copy link
Member

jasmainak commented Jul 12, 2017

Hey, it's just a requirement from sphinx gallery. Maybe later, we can update this example to plot some quality assurance figure. Like histogram of different types of files in the dataset etc.

@choldgraf
Copy link
Contributor

FWIW it doesn't have to be plot_. It just needs to match some regex pattern. E.g., with Matplotlib I set it so that it matches any filename that doesn't have the letters sgskip in it:

https://github.com/matplotlib/matplotlib/blob/master/doc/conf.py#L102

@jasmainak
Copy link
Member

jasmainak commented Jul 12, 2017

haha, I know @choldgraf :) I added the feature in sphinx-gallery and I'm glad it works so well ;) I can change it here if you insist :)

@choldgraf
Copy link
Contributor

haha - I'm not gonna push one way or the other. but if you think it looks nicer not to have plot_ in every example I won't stop you :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants