Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add recording entity to get_entity_vals #1182

Merged
merged 4 commits into from Oct 26, 2023

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Oct 25, 2023

PR Description

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1182 (b69c14d) into main (80add0f) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   97.63%   97.62%   -0.02%     
==========================================
  Files          40       40              
  Lines        8661     8664       +3     
==========================================
+ Hits         8456     8458       +2     
- Misses        205      206       +1     
Files Coverage Δ
mne_bids/path.py 97.27% <80.00%> (-0.11%) ⬇️

@sappelhoff sappelhoff changed the title Add recording entity to get_entity_vals [MRG] Add recording entity to get_entity_vals Oct 25, 2023
@sappelhoff sappelhoff merged commit 24be254 into mne-tools:main Oct 26, 2023
16 of 18 checks passed
@sappelhoff sappelhoff deleted the recording branch October 26, 2023 07:47
@moritz-gerster
Copy link
Contributor

Nice, thank you for solving my issue @sappelhoff! :)

@sappelhoff
Copy link
Member Author

Nice, thank you for solving my issue @sappelhoff! :)

took some time yesterday morning before the presentations ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_entity_vals() does not support the 'recording' entity
3 participants