Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning: with copy=False --> set default explicity #1190

Closed
sappelhoff opened this issue Nov 13, 2023 · 5 comments · Fixed by #1191
Closed

FutureWarning: with copy=False --> set default explicity #1190

sappelhoff opened this issue Nov 13, 2023 · 5 comments · Fixed by #1191

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Nov 13, 2023

https://github.com/mne-tools/mne-bids/actions/runs/6845626385/job/18611114921#step:20:510

FutureWarning: The current default of copy=False will change to copy=True in 1.7. Set the value of copy explicitly to avoid this warning

affects all get_data calls for Epochs

@drammock
Copy link
Member

cross-ref mne-tools/mne-python#12121

@larsoner
Copy link
Member

I'll take a look.

@sappelhoff WDYT about cutting a MNE-BIDS point release today or tomorrow so the copy=False fix can make it into the 1.6 installers?

@sappelhoff
Copy link
Member Author

sure, I can make a 0.13.1 release once the copy=False fix is in 👍

@larsoner
Copy link
Member

... actually it looks like the failure is just in a test not in the code itself so I don't think a release will be necessary

@sappelhoff
Copy link
Member Author

even better :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants