MAINT: Update for 1.2 and bump version #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we wait on the GSoC PR? Or still too much WIP? |
|
If you're not totally confident it's usually better to cut a release then merge a big change |
|
@adam2392 all green here. You up for merging and cutting a release? |
|
I'll try to do a release later today! |
|
@adam2392 just a friendly reminder to cut a release when you get a chance |
|
Done! |
|
Thanks! |
tsbinns
pushed a commit
to tsbinns/mne-connectivity
that referenced
this pull request
Dec 15, 2023
* MAINT: Update for 1.2 and bump version * MAINT: Update for Circle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adam2392 we need to remove
_get_argsto comply with 1.2's removal of it. @adam2392 could you merge this if happy and cut a 0.4.0 release?cc @drammock this one needed an update due to
_get_args