Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Switch to setuptools_scm for version #200

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

larsoner
Copy link
Member

  1. Remove old release file (didn't work, tried to install Python 3.1)
  2. Hopefully fix permissions with new release method (it failed even after I enabled it on PyPI, I suspect we needed these two lines) -- @tsbinns wherever you based your code off of we should maybe fix theirs, too
  3. Switch to setuptools_scm rather than bumping version numbers manually

@larsoner
Copy link
Member Author

@tsbinns can you review and approve if you're happy? Then I'll mark for merge-when-green.

@tsbinns
Copy link
Collaborator

tsbinns commented Jun 12, 2024

Hopefully fix permissions with new release method (it failed even after I enabled it on PyPI, I suspect we needed these two lines) -- @tsbinns wherever you based your code off of we should maybe fix theirs, too

@larsoner Came from mne-bids-pipeline: https://github.com/mne-tools/mne-bids-pipeline/blob/main/.github/workflows/release.yml
Want me to submit a PR there or would you just change it?

@drammock drammock enabled auto-merge (squash) June 12, 2024 15:43
@larsoner
Copy link
Member Author

Feel free to make a PR there to add the permission line and remove the __token__ stuff, I just enabled trusted publishing for that project on PyPI as well 👍

@drammock drammock merged commit 72598dd into mne-tools:main Jun 12, 2024
11 of 12 checks passed
@larsoner larsoner deleted the packaging branch June 12, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants