Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add append capability and events storage in connectivities #49

Merged
merged 7 commits into from
Oct 28, 2021

Conversation

adam2392
Copy link
Member

PR Description

Fixes: #22
Fixes: #48

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@adam2392 adam2392 marked this pull request as draft October 11, 2021 14:34
@adam2392 adam2392 marked this pull request as ready for review October 27, 2021 00:29
@adam2392
Copy link
Member Author

@larsoner I'm just getting things ready on this end for whenever Epochs can support Annotations. This PR will make sure the sample times of each epoch are carried over into the Epoch*Connectivity data structures.

I mostly copy pasted code from MNE-Python

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam2392 adam2392 merged commit 48c0374 into mne-tools:main Oct 28, 2021
@adam2392 adam2392 deleted the events branch October 28, 2021 17:50
tsbinns pushed a commit to tsbinns/mne-connectivity that referenced this pull request Dec 15, 2023
…-tools#49)

* Adding test units

* Adding updated event test

* Fixing unit tests and ci

* merging

* Adding fixes to the n epochs issue

* Fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an append function for appending different connectivities Preserve events from Epochs -> Connectivity
2 participants