Update time.py due to error in spectral_connectivity_time #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SezanMert
changed the title
|
Thanks for the PR and spotting this issue @SezanMert ! Can you add a changelog entry to the And are you up to write a short unit-test that broke on the old version before this change, but works now? |
adam2392
reviewed
Jun 14, 2022
| @@ -6,3 +6,4 @@ | |||
| .. _Alex Rockhill: https://github.com/alexrockhill | |||
| .. _Szonja Weigl: https://github.com/weiglszonja | |||
| .. _Kenji Marshall: https://github.com/kenjimarshall | |||
| .. _Sezan Mert: https://github.com/SezanMert | |||
There was a problem hiding this comment.
@adam2392 Yes! Thank you!
|
@adam2392 FYI the AZP failure here is a GitHub problem relating to the testing-data repo. |
I'm going to just merge as is then for now... |
adam2392
approved these changes
Jun 14, 2022
|
Thanks @SezanMert for the in depth issue and easy fix! |
tsbinns
pushed a commit
to tsbinns/mne-connectivity
that referenced
this pull request
Dec 15, 2023
* Update time.py * Fixed unit test Co-authored-by: Adam Li <adam2392@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
It is the prospective solution of #95
It fixes the incompatibility of dimensions of frequencies in the creation of EpochSpectroTemporalConnectivity object on line 223 by providing the frequencies of interest into the object, rather than the frequencies used in the time-frequency decomposition.
Merge Checklist
Maintainer, please confirm the following before merging: