[WIP] Improvements to feature naming #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertjb
commented
Dec 1, 2020
agramfort
approved these changes
Dec 1, 2020
agramfort
reviewed
Dec 1, 2020
doc/whats_new.rst
Outdated
|
|
||
| Bug | ||
| ~~~ | ||
|
|
||
| - Fixed the behavior of the `edge` parameter in :func:`mne_features.univariate.compute_spect_edge_freq`. Valid values for this parameter are now `None` or a list of float between `0` and `1` (percentages). By `Jean-Baptiste SCHIRATTI`_ in `#52 <https://github.com/mne-tools/mne-features/pull/52>`_. | ||
| - Fixed channel name replacement with overlapping channel names (e.g., Cz and FCz) in :func:`mne_features.feature_extraction._apply_extractor`. By `Hubert Banville`_ in `#63 <https://github.com/mne-tools/mne-features/pull/63>`_. |
There was a problem hiding this comment.
don't document changes in private functions. Say which public functions are affected and how
…ption to pass ``ch_names`` as for univariate functions - fixed channel name replacement with overlapping channel names (e.g., Cz and FCz)
|
thx @hubertjb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last PR for today. :)
This PR (1) extends feature naming with channel name replacement to bivariate functions as for univariate functions, and (2) fixes channel name replacement when we have overlapping channel names (e.g., Cz and FCz).