New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the selection of onnx, torch without requiring both installed #130
Add support for the selection of onnx, torch without requiring both installed #130
Conversation
And for now in this PR, selection can not be done at the top level, |
Do you want me to add it here? If you run that, it will possibly change a lot of files. Nbd imo, but just wanted to make sure |
Not in this PR, would make review too messy. |
The |
@adam2392 What is your opinion on this? |
I like the idea of this in principle in the long run because ideally we can run some other stuff that doesn't require the deep-learning models. But for now, if we really do "require" torch, I would say let's default to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CIs work
OK, great. Let's go with that then, and let's try to setup ONNX as the default in the conda-forge package if that helps packaging on windows. CIs should come back green, merging once that's the case. |
…mne-tools#130" This reverts commit 3e2f929.
It's still a draft.
IMO, we should ship one of the backend via pip install without requiring an optional key.
+1 to keep torch as "default" since that's what we started with. For now in the PR, I moved both dep. to an extra-key but I don't like this solution as it means that
pip install mne_icalabel
now leads to a "broken" package.However, we don't need to have the same default on PyPI and conda-forge, or the same default on all platform if that can make packaging on conda-forge easier.
This PR moves the network part to a separate module. The selection itself is donoe in
network/__init__.py
inrun_iclabel
. Seems to work locally, but I haven't run the full tests.Also, @adam2392 would you mind changing the black default to 88 characters to match MNE?