-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add API for bids pipeline annotating #60
Conversation
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 97.80% 96.22% -1.59%
==========================================
Files 12 15 +3
Lines 501 556 +55
==========================================
+ Hits 490 535 +45
- Misses 11 21 +10
Continue to review full report at Codecov.
|
So simple, I love it :) The API from |
Does this allow for a component to be labeled with different labels by different authors? |
Unfortunately no... So I would say perhaps the tsv file stores the "final annotation" and optionally a score produced if it was an automated method Perhaps what is better is a JSON, where there is a dict of lists with keys:
And then someone can leverage the JSON to formulate the "labels" training/testing dataset. How does this sound? |
Yes, I think that would be better 👍 |
@sappelhoff and @hoechenberger I know BIDS isn't set yet, but wdyt about this for ICA derivatives to handle the problem of annotating labels manually? Anything you think we might be missing? If this works well, perhaps it'll be a good explicit use case for BIDS-EEG-Derivatives to see and use for their specification for ICA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as long as you mark this as "experimental / development" (with regards to BIDS) it can spark further discussion in bids-standard/bep021#5 and https://bids.neuroimaging.io/bep021 👍
PR Description
Addresses the API needed for the annotation GUI to interface with BIDS files of #12
Merge checklist
Maintainer, please confirm the following before merging: