Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICLabel topographic features on ICA fitted with channel selection #68

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

mscheltienne
Copy link
Member

Closes #67.

Someone was going to run into it at some point.. turns out it was me from the future:

# TODO: Selection of channels is missing.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #68 (c4d08d2) into main (ecc6a91) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   96.22%   96.75%   +0.53%     
==========================================
  Files          15       15              
  Lines         556      555       -1     
==========================================
+ Hits          535      537       +2     
+ Misses         21       18       -3     
Impacted Files Coverage Δ
mne_icalabel/datasets/icalabel/icalabel.py 100.00% <ø> (ø)
mne_icalabel/iclabel/features.py 100.00% <100.00%> (+1.44%) ⬆️
mne_icalabel/iclabel/utils.py 92.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a411e45...c4d08d2. Read the comment docs.

@mscheltienne
Copy link
Member Author

mscheltienne commented Jun 16, 2022

Still some dataset download issue..
Tests are green locally, I'll merge.

@mscheltienne mscheltienne merged commit ab090dd into mne-tools:main Jun 16, 2022
@mscheltienne mscheltienne deleted the fix_ch_mismatch branch June 16, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICLabel topographic feature fails if ICA and Raw have a channel mismatch
1 participant